Update dig_channel_activity_actor::finish to match dig_activity_actor::finish #40282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to take into account npc helpers To make it synchronize with dig_activity_actor::finish
…into update-dig-channel
This was referenced May 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Balance "Update character modifications in
dig_channel_activity_actor::finishto matchdig_activity_actor::finish"Purpose of change
When working on #40126, I noticed that the character modifications in the finish function for
ACT_DIG_CHANNELdid not match those of the finish function forACT_DIG. Specifically,ACT_DIGconsidered helpers and also usedmod_stored_nutrinstead ofmod_hunger. I have updated the finish function forACT_DIG_CHANNELto modify the character in the same way asACT_DIG.Describe the solution
Copied the relevant code from
act_dig_activity_actor::finish.Describe alternatives you've considered
Not changing it.
Testing
Spawned npcs and made sure the character modifications used the correct value.
Additional context